Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3546

to review the following change.

Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block 
manager
......................................................................

deltafile-test: fix TestEmptyFileIsAborted for file block manager

This should improve life for the macOS folks.

I thought about explicitly aborting the block (to delete it) in
DeltaFileWriter::Abort(), but reasoned that the impact would be minimal, as
DeltaFileWriters are short-lived to begin with, and as best I can tell, no
code depends on those blocks vanishing immediately.

Change-Id: Icc27ac5555ceb49a010b2b4fbc5123e0c4fdfb5a
---
M src/kudu/tablet/deltafile-test.cc
1 file changed, 9 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/3546/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc27ac5555ceb49a010b2b4fbc5123e0c4fdfb5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to