Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3551

to review the following change.

Change subject: Make dist_test.py work on a symlinked work directory
......................................................................

Make dist_test.py work on a symlinked work directory

Previously, if run inside a directory that was under a symlink,
dist_test.py would not correctly determine whether libraries were from
the system or from the Kudu build. This would cause run_dist_test.py to
incorrectly put all libraries in LD_LIBRARY_PATH. This could result in
errors that looked like the following when trying to symbolize stack
traces under TSAN:

/tmp/run_tha_testQiFa2H/thirdparty/installed/bin/llvm-symbolizer: symbol lookup 
error:
/tmp/run_tha_testQiFa2H/build/dist-test-system-libs/libstdc++.so.6: undefined 
symbol: __tsan_init

With these changes, classification of system vs Kudu build libraries
works correctly under those conditions, and symbolization now works.

run_dist_test.py just has a cosmetic change to rename a variable for
clarity. No functional changes.

Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
---
M build-support/dist_test.py
M build-support/run_dist_test.py
2 files changed, 36 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to