Adar Dembo has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections ......................................................................
Patch Set 1: I've been reviewing the test failure and reproducing it locally. I think I need to continue incorporating leader_term_ into the check in some way; at least checking that it's not -1, I believe. Otherwise it's possible for a caller to grab a ScopedLeaderSharedLock just as the master is starting up, determine that the master is the leader, and let go of the lock, after which VisitTablesAndTablets grabs the lock and begins loading metadata. -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No