Dan Burkert has posted comments on this change.

Change subject: Changes: In kudu-spark, added support to delete rows from Kudu 
table  in DataSource API. This is done using the SaveMode.ErrorIfExists.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3552/2//COMMIT_MSG
Commit Message:

Line 7: Changes: In kudu-spark, added support to delete rows from Kudu table 
please remove trailing whitespace here and below.


Line 14:   .mode(SaveMode.ErrorIfExists).kudu
> Why are you using 'ErrorIfExists' here? It's not what is documented for tha
Agreed, I think a better way to expose this would be an implicit method on RDDs 
named something like "deleteFromKuduTable".  See the Cassandra spark 
connector's "saveToCassandra" for something similar.


Line 21:     * If there are additional columns along with primary columns, 
> seems a little unintuitive here to ignore the extra columns, IMO. what do o
I don't think it will cause problems to ignore them.


-- 
To view, visit http://gerrit.cloudera.org:8080/3552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf7207d5ee525c07b54f7544e0ba63deb47e6acd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to