Ram Mettu has posted comments on this change.

Change subject: Changes: In kudu-spark, added support to delete rows from Kudu 
table  in DataSource API. This is done using the SaveMode.ErrorIfExists.
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3552/2//COMMIT_MSG
Commit Message:

Line 7: Changes: In kudu-spark, added support to delete rows from Kudu table 
> please remove trailing whitespace here and below.
Sure will fix it


Line 14:   .mode(SaveMode.ErrorIfExists).kudu
> Why are you using 'ErrorIfExists' here? It's not what is documented for tha
There is no delete mode in the data source api. So we are trying to fit it into 
one of the 4 defined options. Dan is suggesting a different approach will take 
a look


Line 14:   .mode(SaveMode.ErrorIfExists).kudu
> Agreed, I think a better way to expose this would be an implicit method on 
Ok will look into it


Line 21:     * If there are additional columns along with primary columns, 
> I don't think it will cause problems to ignore them.
Ran into issues having extra columns expect the primary cols in newDelete 
operation. I can post the error if delete is supposed to work fine with extra 
columns.


-- 
To view, visit http://gerrit.cloudera.org:8080/3552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf7207d5ee525c07b54f7544e0ba63deb47e6acd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to