Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#15). Change subject: Integrate the result tracker with writes ...................................................................... Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 25 files changed, 423 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/15 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>