Todd Lipcon has posted comments on this change.

Change subject: Add a test for the integration of RequestTracker with the 
client and ResultTracker with the server
......................................................................


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3505/9//COMMIT_MSG
Commit Message:

Line 7: Add a test for the integration of RequestTracker with the client and 
ResultTracker with the server
hrm, this commit message seems inaccurate - this is an RPC-system-only test, 
right?


http://gerrit.cloudera.org:8080/#/c/3505/9/src/kudu/rpc/rpc-stress-test.cc
File src/kudu/rpc/rpc-stress-test.cc:

PS9, Line 143: very short timeout
I dont see the very short timeout


Line 172:       rpc_->SendRpc();
where's the sleep? need to update some comments?


PS9, Line 207: random amount
not random?


-- 
To view, visit http://gerrit.cloudera.org:8080/3505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to