Hello David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3583
to review the following change.
Change subject: master: handle RPC responses on reactor threads
......................................................................
master: handle RPC responses on reactor threads
The introduction of the election rwlock requires that the handling of RPC
responses move off of the singleton thread pool used for invoking the
election callback, otherwise waiting on outstanding RPCs could lead to a
deadlock. Rather than introduce a new thread pool, I observed that none of
the responses take a lock or perform IO, so we can simplify the code a bit
by operating directly on the reactor threads.
There is one exception to the above statement: retried RPCs invoke Run() on
the reactor thread, and Run() can (theoretically) block on DNS resolution.
This has always been the case, though, so maybe we don't care?
Change-Id: I1af5a77ffa66fcc39f71243529a40aae2b542971
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 16 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/3583/1
--
To view, visit http://gerrit.cloudera.org:8080/3583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1af5a77ffa66fcc39f71243529a40aae2b542971
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
