Dan Burkert has posted comments on this change.

Change subject: [java-client] Fix a hang in TabletClient
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3586/1//COMMIT_MSG
Commit Message:

Line 9: TabletClient#sendRpc has been changing a lot lately, and it's a finicky.
s/a finicky/finicky


http://gerrit.cloudera.org:8080/#/c/3586/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:

PS1, Line 190: encodedRpcAndId can only be null if chan was null.
I think this is more clear as 'encodedRpcAndId is null iff chan is null'


-- 
To view, visit http://gerrit.cloudera.org:8080/3586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f92a2f9464f245182a59178f2eab8a88422864c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to