Todd Lipcon has posted comments on this change.

Change subject: KUDU-763 consensus queue metrics on followers are messed up
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3501/5/src/kudu/consensus/consensus_queue-test.cc
File src/kudu/consensus/consensus_queue-test.cc:

PS5, Line 822: as a followe
this seems to conflict with the 'SetLeaderMode' call below?


Line 827:   queue_->SetNonLeaderMode();
oh, I see, you change it to non-leader. perhaps just update the comment above a 
bit


Line 851:   // Committed index should be the same.
I'm not sure why this patch is changing the committed index metric to not 
advance on followers. It should be available (the leader propagates it to the 
followers), right? And I think it's useful to see if a follower got 
disconnected for some period of time (you'll see the committed index not 
advancing)


-- 
To view, visit http://gerrit.cloudera.org:8080/3501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb0d45f85786b9e2631b5dc0bf044a9d3192a39
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to