David Ribeiro Alves has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3593/4/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: Line 814: const typename MapContainer::value_type::second_type& > I won't be surprised if you need a non-const reference return value instead yeah, tsan didn't like it. change this to return typename MapContainer::value_type::second_type* const like other methods above -- To view, visit http://gerrit.cloudera.org:8080/3593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba9fa8038e699e66d34ce541cd02c77f46691315 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
