David Ribeiro Alves has posted comments on this change.

Change subject: Add a RpcContext::RespondFailure() method
......................................................................


Patch Set 15:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3191/15/src/kudu/rpc/rpc_context.h
File src/kudu/rpc/rpc_context.h:

PS15, Line 88: uce
> typo
Done


PS15, Line 89: cl
> typo
Done


Line 91:   void RespondFailure();
> I still think this would be less confusing if it were called 'RespondNoCach
the problem is that results are not always being cached and for most RPCs the 
user will not know what "cache" means. IMO having a consistent RespondFailure() 
when we, well, failed. is less confusing than failing and using 
RespondSuccess(). Finally I think the better option would be to make _all_ the 
RespondFailure() methods overloads, so that it becomes clear which one to use 
depending on what error type the user wants to set (along with some docs, of 
course)


-- 
To view, visit http://gerrit.cloudera.org:8080/3191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2
Gerrit-PatchSet: 15
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to