David Ribeiro Alves has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
......................................................................


Patch Set 3:

(3 comments)

I'm rejiggering the patches but I don't think we need to merge them all, so at 
least for now, keeping this one separate.

http://gerrit.cloudera.org:8080/#/c/3503/1/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

PS1, Line 171: RPCs that require exactly once semantics can benefit from them 
by enabling
             : the 'track_rpc_result' option when declaring a service interface 
method.
> Nit: how about: "RPCs that require exactly once semantics can enable them b
Done


PS1, Line 191: no automatic
             : care
> Nit: "automatic care" is a strange phrase. Can you reword?
Done


http://gerrit.cloudera.org:8080/#/c/3503/3/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

Line 192: care is taken to persist results (make responses live through 
restarts),
> see comments on earlier rev about some of the wording
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to