David Ribeiro Alves has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3569/2/src/kudu/rpc/result_tracker.cc
File src/kudu/rpc/result_tracker.cc:

Line 329: string ResultTracker::DumpStateToString() {
> rename to 'ToStringUnlocked'?
Done


Line 333:     result.append(Substitute("\n\tClient: $0, $1", cs.first, 
cs.second->ToString()));
> can use SubstituteAndAppend
Done


Line 344:     result.append(Substitute("\n\tCompletion Record: $0, $1", 
completion_record.first,
> same
Done


Line 356:     result.append(Substitute("\n\t$0", orpc.ToString()));
> same
Done


http://gerrit.cloudera.org:8080/#/c/3569/2/src/kudu/rpc/result_tracker.h
File src/kudu/rpc/result_tracker.h:

Line 217:     std::string ToString();
> should this (and probably others) be const?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to