Dan Burkert has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3607/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 880: SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s); While we're revisiting this code-- is TABLE_NOT_FOUND really the right error code here? I would have expected TABLE_ALREADY_PRESENT here as well as the failure scenario before. http://gerrit.cloudera.org:8080/#/c/3607/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: Line 1087: CreateTableRequestPB req; Why not use CreateTable here? -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
