Todd Lipcon has posted comments on this change.

Change subject: Add a EraseKeyReturnSmartPtrValue to map-util
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3595/3/src/kudu/gutil/map-util.h
File src/kudu/gutil/map-util.h:

Line 707: EraseKeyReturnSmartPtrValue(Collection* const collection,
this is more generic than just smart pointer, right? in fact, this is identical 
to the above function except for doing 'std::move' and relying on the default 
constructor instead of just using 'NULL'.

In other words, I think your new function implements the original function too, 
so if you just changed the original to do what you're doing here, you could use 
it in both cases without adding new code?


-- 
To view, visit http://gerrit.cloudera.org:8080/3595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65d17dd26317f77c4c0aa4b8ec00fbe51f8d1ced
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to