David Ribeiro Alves has posted comments on this change.

Change subject: Make EraseKeyReturnValuePtr in map-util work with smart 
pointers.
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3595/3/src/kudu/gutil/map-util.h
File src/kudu/gutil/map-util.h:

Line 707: EraseKeyReturnSmartPtrValue(Collection* const collection,
> this is more generic than just smart pointer, right? in fact, this is ident
Done


Line 711:     return typename Collection::value_type::second_type();
> It seems I missed it first time, but anyways: consider replacing Collection
ended up changing the original function


Line 713:   typename Collection::value_type::second_type value = 
std::move(it->second);
> Ditto: consider changing Collection::value_type::second_type --> Collection
ended up changing the original function


-- 
To view, visit http://gerrit.cloudera.org:8080/3595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65d17dd26317f77c4c0aa4b8ec00fbe51f8d1ced
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to