Dan Burkert has posted comments on this change.

Change subject: rw_mutex: add configurable priority
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3603/1/src/kudu/util/rw_mutex.h
File src/kudu/util/rw_mutex.h:

Line 31:   enum Priority {
> Neat, wasn't aware of this feature. Unfortunately, it makes logging the enu
Fair enough, but I don't think that default case is adding any safety.  Because 
enum classes are not castable to int, it's not really feasible to receive an 
'unknown' variant.  If a variant is added later and the switch is not updated, 
the compiler will issue a warning.


Line 57:   void Init(Priority prio);
> My understanding is that there's no way to "chain" constructors in C++, so 
ah ok I forgot that.  Looks like c++11 has limited support that would probably 
cover this case, but this is enough of a niche feature it's probably not worth 
it.


-- 
To view, visit http://gerrit.cloudera.org:8080/3603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to