Adar Dembo has posted comments on this change. Change subject: c++ client: various fixes to DDL operations ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3608/1/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: PS1, Line 149: num_attempts > make this explicit Done PS1, Line 155: 10 > so many magic numbers.. pull constants/flags? I didn't write this; I just copied it from scanner-internal.cc. I have no idea why this formula was chosen or what the significance of each constant is; Dan put it together for KUDU-1079. But, I took your advice and deduplicated the code. -- To view, visit http://gerrit.cloudera.org:8080/3608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09768240bd04cca95d95aefe17c34d276075125b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
