Adar Dembo has posted comments on this change.

Change subject: rw_mutex: add configurable priority
......................................................................


Patch Set 2:

> Is there any possibility that the different priorities could create
 > a case where OSX would deadlock but Linux wouldn't? am slightly
 > worried about introducing different semantics on the different
 > platforms (and not just a perf difference)

Lock priority can affect starvation or denial of service, but I don't see how 
it could affect deadlocks (which are, in my experience, "provable" one way or 
the other). If a particular application of the new PREFER_WRITING priority 
somehow prevented a deadlock, then before this patch that RWMutex was already 
deadlock prone and buggy.

More concretely, I expect that with this patch, an application of 
PREFER_WRITING on Linux may show better performance or fewer timeouts when 
under stress than the same code on macOS.

-- 
To view, visit http://gerrit.cloudera.org:8080/3603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to