David Ribeiro Alves has posted comments on this change.

Change subject: Add a ResultTracker class that will track server side results
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3190/22/src/kudu/rpc/result_tracker.cc
File src/kudu/rpc/result_tracker.cc:

Line 203:   // from before we reply to all the other ongoing ones.
> why are we guaranteed that 'completion_record' that we're copying from is a
So its like this:
The client's completion record is either the first or the second (depending on 
whether it arrived before the follower txn or not):
- If it arrived first, then we might be copying from it and we're sure that's 
ok, cuz if the last one we'll iterate though.
- If it arrived second, then we won't be copying from it anyway (the txn owns 
the response and there is no context, so it won't be destroyed because we 
replied)


-- 
To view, visit http://gerrit.cloudera.org:8080/3190
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1
Gerrit-PatchSet: 22
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to