Mike Percy has posted comments on this change.

Change subject: Update docs on how to run gcovr
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc
File README.adoc:

PS1, Line 221: gcc (not clang)
> this part is also incorrect (my fault for missing it originally)
Done


Line 241: $ mkdir cov_html
> ah, right
I actually put this back, but in a manner that makes sense.


Line 245:       --html --html-details -o coverage.html
> I'm not sure. I'll try it out.
Seems broken. It says:

mpercy@mpercy-ThinkPad-T530:~/src/kudu/build/coverage$ 
../../thirdparty/installed/bin/gcovr 
--gcov-executable=$(pwd)/../../build-support/llvm-gcov-wrapper --html 
--html-details
Traceback (most recent call last):
  File "../../thirdparty/installed/bin/gcovr", line 1970, in <module>
    print_html_report(covdata, options.html_details)
  File "../../thirdparty/installed/bin/gcovr", line 1373, in print_html_report
    ttmp = os.path.abspath(options.output).split('.')
  File "/usr/lib/python2.7/posixpath.py", line 360, in abspath
    if not isabs(path):
  File "/usr/lib/python2.7/posixpath.py", line 54, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'


-- 
To view, visit http://gerrit.cloudera.org:8080/3508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to