Adar Dembo has posted comments on this change.

Change subject: [c++-client]: cache non-covering ranges in meta cache
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3581/1/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 283:     DCHECK_NOTNULL(tablet_.get());
> That doesn't compile since tablet_ is not a pointer.
Maybe "return DCHECK_NOTNULL(tablet_.get());" then?

Would be good to avoid that warning.


Line 311:   // Returns true if this meta cache entry is stale.
> Yes, it will probably crash.  Having the table is necessary for any kind of
Can you rename the function then? I really prefer to see ToString() as a no-arg 
method like in Java, and to use an alternative name (e.g. DebugString(), 
PartitionDebugString(), things like that) for cases like this.


-- 
To view, visit http://gerrit.cloudera.org:8080/3581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to