David Ribeiro Alves has posted comments on this change.

Change subject: Disable exactly once semantics by default and add a flag to 
enable it for tests
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3506/8//COMMIT_MSG
Commit Message:

Line 14: Note that the flag was added to env.cc as it had to be added somwhere 
that would
> hrmmm... I'm not a fan of this.
changed the flag to be enabled server side and changed this too.


http://gerrit.cloudera.org:8080/#/c/3506/8/src/kudu/rpc/retriable_rpc.h
File src/kudu/rpc/retriable_rpc.h:

Line 193:   if (FLAGS_enable_exactly_once) {
> I think having the kill switch on the server side is preferable
Done


http://gerrit.cloudera.org:8080/#/c/3506/8/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

Line 86:   FLAGS_enable_exactly_once = true;
> I don't think this is quite sufficient, because it won't enable it on exter
it was sufficient, since the flag was client side, but it isn't anymore. so 
added the flag where appropriate.


-- 
To view, visit http://gerrit.cloudera.org:8080/3506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to