David Ribeiro Alves has posted comments on this change.

Change subject: Integrate the request tracker with the client
......................................................................


Patch Set 25:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3080/25/src/kudu/rpc/rpc-stress-test.cc
File src/kudu/rpc/rpc-stress-test.cc:

PS25, Line 278: attempted multiple times
> i think worth saying that it's attempted multiple times because the server 
Done


PS25, Line 283: nu
> nit: capital 'n'
Done


http://gerrit.cloudera.org:8080/#/c/3080/25/src/kudu/rpc/rtest.proto
File src/kudu/rpc/rtest.proto:

Line 113:   optional bool may_fail = 3 [default = false];
> nit: I think a better name would be 'randomly_fail' or 'inject_failures'
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee
Gerrit-PatchSet: 25
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to