David Ribeiro Alves has posted comments on this change.

Change subject: [java client] Integrate with the replay cache
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3631/2//COMMIT_MSG
Commit Message:

PS2, Line 12: One major change in this patch is that the Flume, Spark, and MR 
bindings stop
            : using setIgnoreAllDuplicateRows()
> I don't know if this is a good idea. I like to think that it is, but maybe 
yeah, I think we shouldn't change the default behavior without notice (i.e. 1 
release in between) even if replay cache is super solid and reliable.
Moreover I'd definitely like to have this patch in before that so that we can 
start acummulating coverage


-- 
To view, visit http://gerrit.cloudera.org:8080/3631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to