Will Berkeley has posted comments on this change.

Change subject: Fix encoding-test on OS X
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3640/1/src/kudu/cfile/encoding-test.cc
File src/kudu/cfile/encoding-test.cc:

Line 80:       string *val = new string(StringPrintf(fmt_str, i));
> This is leaking the string since it's never deallocated.  I think the fix h
Yeah my bad...that was pretty obvious. Thanks for the quick comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie221906ee3960fa158843c2ae2dd7a531e74c5c4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to