Adar Dembo has posted comments on this change.

Change subject: rw_mutex: add configurable priority
......................................................................


Patch Set 3:

> I have experienced in the past an issue where the fairness policy
 > causes a deadlock. See 
 > https://issues.apache.org/jira/browse/HDFS-2223?focusedCommentId=13097647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13097647
 > for example.
 > 
 > I think the issue only happens when you recursively acquire the
 > read lock, or if you are holding the read lock while waiting on
 > another thread which needs to acquire the read lock. I'm not sure
 > if we have cases of either, but we should probably document this
 > danger.

I see.

I added a comment to the fairness policies to highlight the dangers. I've also 
got a follow-on patch that prohibits recursive locking altogether, so that 
should help too.

-- 
To view, visit http://gerrit.cloudera.org:8080/3603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: No

Reply via email to