Adar Dembo has posted comments on this change.

Change subject: [java client] Redo how we manage exceptions
......................................................................


Patch Set 7:

(3 comments)

Only a few nits left.

When you're done, could you make a pass over the client-consuming modules in 
the java subdirectory and update their exception handling, if need be? In a 
separate patch, of course.

http://gerrit.cloudera.org:8080/#/c/3055/7/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java
File 
java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java:

Line 25: @InterfaceAudience.Public
Hmm, shouldn't this be Private?


http://gerrit.cloudera.org:8080/#/c/3055/7/java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java
File java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java:

Line 55:                     int numRows, Slice bs, Slice indirectBs) {
Nit: indentation here looks off.


PS7, Line 66:                                                         Schema 
schema,
            :                                                         
WireProtocol.RowwiseRowBlockPB data,
            :                                                         final 
CallResponse callResponse)
Nit: here too.


-- 
To view, visit http://gerrit.cloudera.org:8080/3055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to