Dan Burkert has posted comments on this change.

Change subject: [c++-client]: cache non-covering ranges in meta cache
......................................................................


Patch Set 4:

(2 comments)

Added ttl config to master and a TTL expiry test, as well as a fix for ksck 
when operating on tables with non-covered ranges.

http://gerrit.cloudera.org:8080/#/c/3581/1/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

Line 283:   const scoped_refptr<RemoteTablet>& tablet() const {
> Maybe "return DCHECK_NOTNULL(tablet_.get());" then?
That wouldn't type check.  I'm not seeing a warning with clang or gcc 4.9, so 
I'm not sure how to check what is a better approach.  Would 
DCHECK(tablet_.get() != nullptr) work?


Line 311:     DCHECK(expiration_time.Initialized());
> Can you rename the function then? I really prefer to see ToString() as a no
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to