Jean-Daniel Cryans has posted comments on this change.

Change subject: [c++-client]: cache non-covering ranges in meta cache
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3581/4/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

PS4, Line 793: that the if the
nit


PS4, Line 801: InsertOrDie(&tablets_by_key, "", std::move(entry));
So this means we make the whole key space non-covered?

What if the user deleted all the tablets and started adding them back... 
wouldn't we basically block unlucky clients for "expiration_time" who queried 
the master when the table reached 0 tablets?

I dont' remember if we decided to start supporting re-adding tablets in a 
previously-occupied key space.


-- 
To view, visit http://gerrit.cloudera.org:8080/3581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to