Dan Burkert has posted comments on this change.

Change subject: KUDU-1311 [master] support adding and dropping range partitions
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.cc
File src/kudu/client/client.cc:

Line 900:     // If there are add partition steps, clear the local meta cache 
so that the
> Not sure I like this, it's pretty heavy handed to clear the whole cache. Al
Added a comment about why clearing the cache is still effective even if the 
alter is not waited on.  As far as the perf. impact of this change, I don't 
expect it to happen very often.  I also agree that most instances will be as 
part of something like a CLI tool that has a fresh client anyway.  For 
applications like kudu-ts which have long running clients which may 
occasionally add partitions, I don't think the perf. impact will be that 
meaningful.  We can always revisit if it ends up being a problem.


http://gerrit.cloudera.org:8080/#/c/3648/1/src/kudu/client/client.h
File src/kudu/client/client.h:

PS1, Line 550: // Multiple range partitions may be dropped, but they must all 
exatly match
             :   // one of the tables range partitions.
> So this means that you can drop multiple tablets? So it's not just dropping
No, this would happen if the method is called multiple times as part of a 
single alter operation.


-- 
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to