Adar Dembo has submitted this change and it was merged. Change subject: master: fix corruption when AlterTable() races with CreateTable() ......................................................................
master: fix corruption when AlterTable() races with CreateTable() Admittedly, this is a contrived scenario: 1. T1 tries to create table with name 'foo' 2. T2 tries to rename table with name 'bar' to 'foo' With just the right timing, both operations succeed and the metadata now has two tables named 'foo', each with a different table ID. The fix is simple: generalize the "tables being created" logic already used by CreateTable(). Without the fix, the new test failed every 50th run or so. With it, it doesn't fail in 1000 runs. Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Reviewed-on: http://gerrit.cloudera.org:8080/3607 Reviewed-by: Dan Burkert <d...@cloudera.com> Tested-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master-test.cc 3 files changed, 231 insertions(+), 30 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
