Dinesh Bhat has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3653/1/docs/installation.adoc File docs/installation.adoc: > What is the "XCode package"? Is that something that's totally obvious to a Package itself seems distinct from the cmdline tools, because I had cmdline tools installed before observing build failures. Is Xcode an obvious package for macOS user ? If you are building/developing on mac, I would guess so. Line 474: The Xcode package is necessary for compiling Kudu. Some of the instructions > This can probably be simplified to just say that the full xcode install is Cool, thanks. Line 476: manual dependency installation is possible. > Nit: "...that the Xcode package is..." I figured it's better to remove cli tools references, and just say Xcode needed as Dan is suggesting. -- To view, visit http://gerrit.cloudera.org:8080/3653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8962d5539f437dba8b120c70c90c1e384ed550c9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
