David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: PS5, Line 45: > nit: shouldn't whitespaces trail for multi-line strings? not sure that's a rule. but Done PS5, Line 91: // If the arriving request is older than our per-client GC watermark, report its : // staleness to the client. > This is fatal, right? There's nothing the client can do? you mean fatal in the sense that the client can't recover? yeah (not in the "crash the server" sense though) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: PS5, Line 227: ClientSttate > nit Done -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes