Adar Dembo has posted comments on this change.

Change subject: [c++-client]: cache non-covering ranges in meta cache
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3581/7/src/kudu/client/meta_cache.cc
File src/kudu/client/meta_cache.cc:

Line 816:     // A response containing B, D and E could occur if the lookup 
partition key
Nit: Could you reword this so that the A in "A response..." doesn't seem like a 
reference to the non-covered range A?


http://gerrit.cloudera.org:8080/#/c/3581/7/src/kudu/gutil/map-util.h
File src/kudu/gutil/map-util.h:

Line 207: // Same as above, but returns a const reference.
Not quite; 'above' is not a OrDie method.


-- 
To view, visit http://gerrit.cloudera.org:8080/3581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to