David Ribeiro Alves has posted comments on this change. Change subject: [java client] Integrate with the replay cache ......................................................................
Patch Set 4: (4 comments) looks mostly good, does this still have the side effect of making us not ignore duplicated rows where we did before? http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java: PS4, Line 107: long docs http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/Operation.java File java/kudu-client/src/main/java/org/kududb/client/Operation.java: Line 163: boolean isRetryableRpc() { docs http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 41: public RequestTracker(String clientId) { does the request tracker need to have the client id? http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java: PS4, Line 254: requestIdBuilder.setFirstIncompleteSeqNo(requestTracker.firstIncomplete()); > In the previous patch I wasn't sending this if the value would have been NO thanks -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
