Mike Percy has posted comments on this change.

Change subject: Add dropdown menu for Community nav button
......................................................................


Patch Set 2:

(2 comments)

> One more parting thought: might be worth a <!-- html comment -->
 > here advising people that they shouldn't add any content that is
 > _only_ linked from this dropdown, since the dropdown doesn't show
 > up on mobile.

Done

http://gerrit.cloudera.org:8080/#/c/3665/2/_includes/top_common.html
File _includes/top_common.html:

PS2, Line 74: http://localhost:4000/
> woops
Thanks for the catch


http://gerrit.cloudera.org:8080/#/c/3665/2/css/kudu.css
File css/kudu.css:

Line 125: @media (max-width:870px) {
> it's sort of weird that the dropdown disappears at a different width than t
Changed to max-width:768px (instead of 767px) because I don't think it works 
quite right on iPad yet, and that at least covers vertical iPad. Horizontal 
iPad will see the menu but a click ends up flickering the menu, then going to 
community.html ... but it will take some messing around to deal with that case 
I think since it appears to detect at 1024px


-- 
To view, visit http://gerrit.cloudera.org:8080/3665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c0f2671e2257a4249b4b26d1cc8513ee0e47362
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to