Dinesh Bhat has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3667/1//COMMIT_MSG Commit Message: Line 7: KUDU-1492: Show column encodings/compression on table page in master > This is a good summary of best practices for this: http://chris.beams.io/po yep, that helps. thanks. Line 8: > Usually our commit messages are a little more informative (see other commit thanks, addressed them both. http://gerrit.cloudera.org:8080/#/c/3667/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 35: std::stringstream* output) { > This is not part of this change, but just an additional comment. Does it m That's a good point, I will note this for future changes. I would prefer to keep this as-is otherwise this means changing the signatures of callers too at few other places. Line 39: << "<th>Encoding</th><th>Compression</th>" > How about we use two different columns for each of encoding and compression yep, either way is fine with me. I had clubbed them thinking they both are column attrs. Updated the patch with new output format. PS1, Line 40: > spaces instead of tabs. check out google style guide. Thanks david for catching, yes my editor settings were at default. Line 56: *output << Substitute("<tr><th>$0</th><td>$1</td><td>$2</td><td>$3</td>" > I, as a reader, would appreciate some text example of the output in the com Hmmm, I thought about it, but the output wasn't fitting within 80 columns and spilling over wasn't looking pretty either so chucked that idea. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes