Dan Burkert has posted comments on this change.

Change subject: [c++-client]: cache non-covering ranges in meta cache
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3581/9/src/kudu/client/client.h
File src/kudu/client/client.h:

PS9, Line 293:   FRIEND_TEST(ClientTest, TestGetTabletServerBlacklist);
             :   FRIEND_TEST(ClientTest, TestMasterDown);
             :   FRIEND_TEST(ClientTest, TestMasterLookupPermits);
             :   FRIEND_TEST(ClientTest, TestMetaCacheExpiry);
             :   FRIEND_TEST(ClientTest, TestNonCoveringRangePartitions);
             :   FRIEND_TEST(ClientTest, 
TestReplicatedTabletWritesWithLeaderElection);
             :   FRIEND_TEST(ClientTest, TestScanFaultTolerance);
             :   FRIEND_TEST(ClientTest, TestScanTimeout);
             :   FRIEND_TEST(ClientTest, TestWriteWithDeadMaster);
> Now that the entire test class is marked as a friend, are these still neede
Yes, these individual tests are accessing the data_ field.


-- 
To view, visit http://gerrit.cloudera.org:8080/3581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05bcb3fe05d51d7c455e1d68bd2baa6f3c2b9d21
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to