Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions ......................................................................
Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/3055/8/java/kudu-client/src/main/java/org/kududb/client/KuduClient.java File java/kudu-client/src/main/java/org/kududb/client/KuduClient.java: Line 99: public boolean isAlterTableDone(String name) throws KuduException, InterruptedException { > It's not clear to me why this one throws Interrupted but not any of the oth Ugh yeah looks like in other places where we call Deferred.join we just process everything as Exception. http://gerrit.cloudera.org:8080/#/c/3055/8/java/kudu-client/src/main/java/org/kududb/client/KuduException.java File java/kudu-client/src/main/java/org/kududb/client/KuduException.java: Line 37: * sse if you're using the non-async API, such as {@link KuduSession} instead of > s/sse/see Done http://gerrit.cloudera.org:8080/#/c/3055/8/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java File java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java: Line 26: public class NonCoveredRangeException extends NonRecoverableException { > Can this be default (package private) visibility? Good catch. -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes