Alexey Serbin has posted comments on this change.

Change subject: Doxygen for C++ client API
......................................................................


Patch Set 9:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3619/9/src/kudu/client/client.h
File src/kudu/client/client.h:

> 1. OK, then I think reverting back to one space makes sense.
NP: the crucial part is that we've got some progress :)


Line 432: class KUDU_EXPORT KuduTableCreator {
> I'm referring to how, in some of the old comments here, there were one-word
Oh, I see.  Yes, I also think it's nice to have that information.  I'm about to 
add that as preconditions for appropriate objects.  Please stay tuned -- will 
post with next revision of the patch.


http://gerrit.cloudera.org:8080/#/c/3619/11/src/kudu/client/client.h
File src/kudu/client/client.h:

Line 767:   ///
> Nit: operation
Done


Line 1079:   /// flushes itself inline.
> Will this also include the "Flush any pending writes" sentence from Flush()
Good catch -- yes, that should be fixed.  Done.


Line 1332:   /// @note This method is unstable, and for internal use only.
> Nit: begin scanning
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes

Reply via email to