Adar Dembo has posted comments on this change. Change subject: client/sample.cc: fixed a couple of crashes ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3685/1//COMMIT_MSG Commit Message: Line 11: while logging some messages from terminating reactor threads. > is there another way we can fix this without forcing callers to uninstall t As with the below, any ideas as to why the precommit test didn't experience this? As for a less onerous fix, log_cb could be declared globally so that it doesn't go out of scope at the end of main(). That's probably what "real users" would do anyway. Line 13: Fixed issue with an attempt to access non-existing element > hmm, the bug fix looks reasonable, but I'm curious why we don't see this cr I'm also surprised. front() on an empty vector is undefined behavior, so maybe the precommit compilers elide the entire statement, and Alexei has been using one that doesn't? -- To view, visit http://gerrit.cloudera.org:8080/3685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fa3b812e6402a113bf5e432a3a451dc4cc3735 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
