Adar Dembo has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3648/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 1522: if (has_metadata_changes) { > Yes, that's basically what 'has_metadata_changes' is tracking. But what if !tablets_to_add.empty() and !has_metadata_changes_for_existing_tablets? Seems like that could happen if an AlterTable() comes in that just adds a new partition. In that case, we will set the table's state to ALTERING but not write it out, and revert the change below. That doesn't seem correct. -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
