Alexey Serbin has posted comments on this change.

Change subject: KUDU-1492: Show column encodings/compression on table page in 
master
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/3667/2//COMMIT_MSG
Commit Message:

Line 9: This displays column  atributes for the table schema in picture.
typo: atributes --> attributes


PS2, Line 9:  
nit: an extra space


Line 13: release. For eg, current release has PLAIN_ENCODING for encoding
nit: For eg --> E.g. ?


http://gerrit.cloudera.org:8080/#/c/3667/2/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

PS2, Line 40:   
nit: Is this still a tab?  If yes, consider expanding it with spaces to comply 
with code style.


Line 54:   string encoding = EncodingType_Name(attrs.encoding);
nit: consider replacing with const reference:

const string& encoding = ...


Line 55:   string compression = CompressionType_Name(attrs.compression);
Ditto -- consider replacing with const reference.


-- 
To view, visit http://gerrit.cloudera.org:8080/3667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to