Alexey Serbin has posted comments on this change.

Change subject: KUDU-1492: Show column encodings/compression on table page in 
master
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

LGTM, just a small formatting nit.

http://gerrit.cloudera.org:8080/#/c/3667/3/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

Line 53:   const ColumnStorageAttributes& attrs = col.attributes();
nit: it seems the indent for these new lines is off one shiftwidth.  Consider 
shifting them right to align with the rest of the code in the 'for' closure.


-- 
To view, visit http://gerrit.cloudera.org:8080/3667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to