Hello Jean-Daniel Cryans, Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3714

to review the following change.

Change subject: ksck: fix a crash in checksum mode on tables with many tablets
......................................................................

ksck: fix a crash in checksum mode on tables with many tablets

In the case that the list of tablets had to be fetched in multiple
batches, we would improperly re-fetch the last tablet of the previous
batch as the first tablet of the next batch. This would then cause
a tablet to be inserted twice into the list, which would later cause
a CHECK failure when we tried to InsertOrDie() this tablet ID into
a map.

This fixes the issue by making sure that we look for more tablets starting with
the *successor* partition key compared to the previous tablet we fetched.
I also updated the integration test to use a table with more tablets
so that the batching code was exercised.

Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355
---
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
2 files changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/3714/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>

Reply via email to