Adar Dembo has posted comments on this change.

Change subject: KUDU-1358 (part 3): new multi-master stress test
......................................................................


Patch Set 10:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3611/10/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:

Line 87:   virtual void SetUp() OVERRIDE {
> void SetUp() override {
Done


Line 212:         // The client retried after the RPC timed out, but the master 
did in
> Seems to me this is unlikely to timeout, since it's not really doing much o
It's not possible for another thread to race in the rename/delete due to how 
BlockingGetTableName()/PutTableName() work. So this really is all about the 
timeouts.


Line 238:         // TODO: Should be fixed with Exactly Once semantics, see 
KUDU-1537.
> same here
See above.


-- 
To view, visit http://gerrit.cloudera.org:8080/3611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to