Todd Lipcon has posted comments on this change.

Change subject: KUDU-1358 (part 1): master should accept heartbeat even if 

Patch Set 12:

Commit Message:

Line 20: possible; the only way a master can "lose" a cached TSDescriptor is if 
what about when a tserver restarts? is it still going to do a proper full TR 
after the restart, due to some tserver-side logic? are we waiting on the later 
patch in this series to make sure that the tserver logic ensures a full TR 
after a leader change?
File src/kudu/integration-tests/

Line 289:             auto ts = mini_tablet_server->server();
should this verify that the TS process is running? (there's a getter for that). 
Worth documenting either way

Line 299:       }
else LOG(FATAL) perhaps? or use a switch() so that you get a compilation error 
if you were to add a new matchmode
File src/kudu/integration-tests/mini_cluster.h:

Line 145:     // Match the tservers retrieved from each master against the 
tservers in
not sure what 'Match' means here. Is this a verification? (i.e that the count 
and uuids match, and otherwise a bad Status will return?) Could be more clear.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Dan Burkert <>
Gerrit-Reviewer: David Ribeiro Alves <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

Reply via email to