jahstreet commented on pull request #167: URL: https://github.com/apache/incubator-livy/pull/167#issuecomment-874671228
Hi @prongs , thank you for joining the party 🎉 . This PR is outdated and kept just for the discussions (probably I should reflect that in the description). The work done here were split into smaller pieces and the first one lives now in #249 . Please check this block of the code to see how I approached that problem: https://github.com/apache/incubator-livy/pull/249/files#diff-43114318c4b009c2404f7eb326a84c184fb1501a3237c49a771df851d0f6f328R172-R177 . Though I think your solution looks nicer indeed. Worths to look deeper inside. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
